From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17263 invoked by alias); 30 Dec 2007 04:38:55 -0000 Received: (qmail 17254 invoked by uid 22791); 30 Dec 2007 04:38:54 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 30 Dec 2007 04:38:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id BDF5F98019; Sun, 30 Dec 2007 04:38:46 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 7E34A98017; Sun, 30 Dec 2007 04:38:46 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J8pwj-0006S9-IC; Sat, 29 Dec 2007 23:38:45 -0500 Date: Sun, 30 Dec 2007 11:25:00 -0000 From: Daniel Jacobowitz To: Luis Machado Cc: Andreas Schwab , gdb-patches@sourceware.org Subject: Re: GDB/libiberty support for IBM long double Message-ID: <20071230043845.GC24220@caradoc.them.org> Mail-Followup-To: Luis Machado , Andreas Schwab , gdb-patches@sourceware.org References: <200711090107.lA917ZGs027733@d12av02.megacenter.de.ibm.com> <1198783208.7822.51.camel@gargoyle> <1198852288.7822.56.camel@gargoyle> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1198852288.7822.56.camel@gargoyle> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00475.txt.bz2 On Fri, Dec 28, 2007 at 12:31:27PM -0200, Luis Machado wrote: > On Fri, 2007-12-28 at 11:33 +0100, Andreas Schwab wrote: > > That part of the function can be simplified quite a bit. For example, > > NaNs and infinities are already handled at this point, thus > > special_exponent can only be true when the biased exponent is zero. > > Thanks for the feedback Andreas. How should we proceed to get code > included on libiberty? Post a patch to gcc-patches. You may want to compare the libiberty version with the gdb/doublest.c version, which is used otherwise; I believe I introduced a use of the libiberty version for NaNs and Joseph added some others for IBM split long double, but no other platform uses them. So problems are not unlikely. I wonder if we really need to use floatformat_to_double instead of floatformat_to_doublest for the split_half cases. It seems like that relies unnecessarily on the host double format. Do things work better if you use floatformat_to_doublest and DOUBLEST variables, instead of floatformat_to_double (likewise floatformat_from_doublest)? -- Daniel Jacobowitz CodeSourcery