From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14691 invoked by alias); 28 Dec 2007 13:07:34 -0000 Received: (qmail 14683 invoked by uid 22791); 28 Dec 2007 13:07:33 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 28 Dec 2007 13:07:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9D6172A9670; Fri, 28 Dec 2007 08:07:22 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id toN2BJ2+ipHq; Fri, 28 Dec 2007 08:07:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D64812A9661; Fri, 28 Dec 2007 08:07:21 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 93227E7ACB; Fri, 28 Dec 2007 17:07:14 +0400 (RET) Date: Fri, 28 Dec 2007 13:10:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [commit/ada+testsuite] print ada boolean expression results as true/false Message-ID: <20071228130714.GD24450@adacore.com> References: <20071228061513.GA24450@adacore.com> <200712281032.lBSAWfAR000724@brahms.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200712281032.lBSAWfAR000724@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00436.txt.bz2 Hi Mark! Thanks for taking a look at the patch, this is always much appreciated. > > + *pos -= 1; > > + return value_cast (LA_BOOL_TYPE, > > + evaluate_subexp_standard (expect_type, exp, > > + pos, noside)); > > I think the fact that you need three lines here means that it makes > more sense to avoid the nested function calls and use a (temporary) > variable instead. Sure, that's a good idea. Fixed with the attached patch: 2007-12-28 Joel Brobecker * ada-lang.c (ada_evaluate_subexp): Break two large expressions using temporary variables. Tested on x86-linux, no regression. Checked in. -- Joel