From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18312 invoked by alias); 20 Dec 2007 16:58:14 -0000 Received: (qmail 18304 invoked by uid 22791); 20 Dec 2007 16:58:14 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Dec 2007 16:58:07 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 3673498151; Thu, 20 Dec 2007 16:58:06 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 17B8298150; Thu, 20 Dec 2007 16:58:06 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J5Oij-0004el-3n; Thu, 20 Dec 2007 11:58:05 -0500 Date: Thu, 20 Dec 2007 17:07:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, David Ung , "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Sign-extend pointers for n32 Message-ID: <20071220165805.GB17663@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, David Ung , "Maciej W. Rozycki" References: <20071216184625.GA22905@caradoc.them.org> <20071219152826.GA30488@caradoc.them.org> <20071219161552.GA1280@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00346.txt.bz2 On Thu, Dec 20, 2007 at 04:37:31PM +0000, Maciej W. Rozycki wrote: > Thus I have taken your suggestion into account and modified the change > further as follows and regression tested it as previously, successfully. > Well, I guess it actually means we do not really have a terribly good > coverage here -- I suppose a set of test cases that would check that > promotion is performed correctly with manual calls would be useful. > > 2007-12-19 David Ung > Maciej W. Rozycki > > * mips-tdep.c (mips_n32n64_push_dummy_call): Sign-extend > integers and 32-bit pointers as required by the ABI. > > OK to apply? OK. I think there's still a problem here, though it is somewhat endemic to the argument passing routines: TYPE_CODE_ENUM, /* Enumeration type */ TYPE_CODE_REF, /* C++ Reference types */ TYPE_CODE_CHAR, /* *real* character type */ TYPE_CODE_BOOL, And possibly TYPE_CODE_MEMBERPTR too... that's a signed offset, probably 32-bit in the n32 case. Getting this right is a real pain. -- Daniel Jacobowitz CodeSourcery