Re: [patch 2/2] Wrap-up expression support for DFP.

Thiago Jung Bauermann
2008-01-02T16:42:20Z

On Sat, 2007-12-29 at 13:47 +0200, Eli Zaretskii wrote:
> > From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> > Cc: gdb-patches@sourceware.org
> > Date: Fri, 28 Dec 2007 02:33:07 -0200
> >
> > I couldn't find an appropriate place to put these in the manual, so I
> > went ahead and created a new sub-section, under "Examining Data". What
> > do you think?
>
> I think a better place is in the "C and C++" section. These are C/C++
> data types, aren't they?
>
> > +There are two encodings in use, depending on the architecture: BID (Binary
> > +Integer Decimal) for x86 and x86-64, and DPD (Densely Packed Decimal) for
> > +PowerPC. GDB will use the appropriate encoding for the configured target.
>
> PLease use "@value{GDBN}" instead of a literal "GDB".
>
> > +Because of a limitation in libdecnumber, the library used by @value{GDBN}
>
> "libdecnumber" is a file name, so it should have the @file markup.
>
> > +point computations, error checking in decimal float operations ignore underflow,
>
> "ignores".
>
> Other than these comments, the patch is okay to go in (as a subsection
> of the "C and C++" section.

Ok, changed the patch to abide to all observations above. I will commit
it when the code patch is approved as well. Thanks for your review.