From: DJ Delorie <dj@redhat.com>
To: gdb-patches@sourceware.org
Cc: brolley@redhat.com
Subject: [frv sim] clip cut point for MWCUT
Date: Tue, 18 Dec 2007 21:59:00 -0000 [thread overview]
Message-ID: <200712182145.lBILjvWJ028114@greed.delorie.com> (raw)
The MWCUT opcode only looks at the six LSBs of the cut point register.
The frv.c code was looking at the whole register, resulting in
incorrect cut results. This patch clips the cut_point argument to six
bits (0..63). Ok to apply?
* frv/frv.c (frvbf_cut): Only look at the six LSBs of
cut_point.
Index: frv.c
===================================================================
RCS file: /cvs/src/src/sim/frv/frv.c,v
retrieving revision 1.9
diff -p -U3 -r1.9 frv.c
--- frv.c 24 Aug 2007 14:28:36 -0000 1.9
+++ frv.c 18 Dec 2007 21:42:50 -0000
@@ -1055,6 +1055,7 @@ SI
frvbf_cut (SIM_CPU *current_cpu, SI reg1, SI reg2, SI cut_point)
{
SI result;
+ cut_point &= 0x3f;
if (cut_point < 32)
{
result = reg1 << cut_point;
next reply other threads:[~2007-12-18 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 21:59 DJ Delorie [this message]
2007-12-19 14:59 ` Dave Brolley
2007-12-20 1:43 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712182145.lBILjvWJ028114@greed.delorie.com \
--to=dj@redhat.com \
--cc=brolley@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox