From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21125 invoked by alias); 17 Dec 2007 14:11:07 -0000 Received: (qmail 21112 invoked by uid 22791); 17 Dec 2007 14:11:05 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 14:10:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4A57E2A9630; Mon, 17 Dec 2007 09:10:54 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id eYwVdAouvAi1; Mon, 17 Dec 2007 09:10:54 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5FE2F2A962D; Mon, 17 Dec 2007 09:10:53 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 91366E7ACA; Mon, 17 Dec 2007 15:10:45 +0100 (CET) Date: Mon, 17 Dec 2007 14:22:00 -0000 From: Joel Brobecker To: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [commit] language.h minor cleanup Message-ID: <20071217141045.GH9022@adacore.com> References: <20071217070301.GE32623@adacore.com> <200712171040.lBHAe0SM002161@brahms.sibelius.xs4all.nl> <20071217104547.GG9022@adacore.com> <20071217132851.GA23128@caradoc.them.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="jousvV0MzM2p6OtC" Content-Disposition: inline In-Reply-To: <20071217132851.GA23128@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00271.txt.bz2 --jousvV0MzM2p6OtC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 845 > q.c:1: warning: ISO C forbids forward references to `enum' types > If we use it elsewhere, we should stop. Humpf, sorry about that. I have reverted this part of my patch as follow: 2007-12-17 Joel Brobecker * language.h (enum exp_opcode): Comment out this declaration, undoing the previous change. Re-tested on x86-linux with a full rebuild. The situation is not completely fixed yet, but we can discuss our options. In terms of other places where it is used, I thought there were several but a quick grep revealed only two: - language.h (our case, enum exp_opcode) - symtab.h (enum language) Unless my egrep command is wrong, I must have some delusional episodes: % grep -E -e 'enum +[_0-9a-zA-Z]+;' **/*.h I will send some patches ASAP. -- Joel (UTC+4 for the next 5 weeks :-). --jousvV0MzM2p6OtC Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="language.h.diff" Content-length: 609 Index: language.h =================================================================== RCS file: /cvs/src/src/gdb/language.h,v retrieving revision 1.44 diff -u -p -r1.44 language.h --- language.h 17 Dec 2007 07:00:49 -0000 1.44 +++ language.h 17 Dec 2007 14:04:59 -0000 @@ -30,7 +30,8 @@ struct objfile; struct frame_info; struct expression; struct ui_file; -enum exp_opcode; + +/* enum exp_opcode; ANSI's `wisdom' didn't include forward enum decls. */ /* This used to be included to configure GDB for one or more specific languages. Now it is left out to configure for all of them. FIXME. */ --jousvV0MzM2p6OtC--