From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26167 invoked by alias); 17 Dec 2007 13:29:05 -0000 Received: (qmail 26158 invoked by uid 22791); 17 Dec 2007 13:29:03 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 13:28:55 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 848C198129; Mon, 17 Dec 2007 13:28:53 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 4928598100; Mon, 17 Dec 2007 13:28:53 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J4G1b-000689-SU; Mon, 17 Dec 2007 08:28:51 -0500 Date: Mon, 17 Dec 2007 13:31:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [commit] language.h minor cleanup Message-ID: <20071217132851.GA23128@caradoc.them.org> Mail-Followup-To: Joel Brobecker , Mark Kettenis , gdb-patches@sourceware.org References: <20071217070301.GE32623@adacore.com> <200712171040.lBHAe0SM002161@brahms.sibelius.xs4all.nl> <20071217104547.GG9022@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071217104547.GG9022@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00267.txt.bz2 On Mon, Dec 17, 2007 at 02:45:47PM +0400, Joel Brobecker wrote: > > As far as I know the comment: > > > > > -/* enum exp_opcode; ANSI's `wisdom' didn't include forward enum decls. */ > > > > is right, so you shouldn't have comitted this :(. Perhaps it is now a > > GCC extension to allow these, but as far as I remember older versions > > of GCC didn't accept this. > > I thought that we changed the requirement to C90 which should accept this. > I was comforted in this direction by the fact that we already use this > paradigm elsewhere so I thought it was OK. Nope, sorry. C99, 6.7.2.3#2: A type specifier of the form enum identifier without an enumerator list shall only appear after the type it specifies is complete. drow@caradoc:~% gcc -c q.c -Wall -std=c99 -pedantic q.c:1: warning: ISO C forbids forward references to `enum' types If we use it elsewhere, we should stop. -- Daniel Jacobowitz CodeSourcery