From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13083 invoked by alias); 17 Dec 2007 10:46:05 -0000 Received: (qmail 13075 invoked by uid 22791); 17 Dec 2007 10:46:05 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 10:45:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EE3472A962F; Mon, 17 Dec 2007 05:45:54 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id O9f2ec2nVU2N; Mon, 17 Dec 2007 05:45:54 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6EC4D2A962D; Mon, 17 Dec 2007 05:45:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 17A36E7ACA; Mon, 17 Dec 2007 11:45:47 +0100 (CET) Date: Mon, 17 Dec 2007 11:23:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [commit] language.h minor cleanup Message-ID: <20071217104547.GG9022@adacore.com> References: <20071217070301.GE32623@adacore.com> <200712171040.lBHAe0SM002161@brahms.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200712171040.lBHAe0SM002161@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00263.txt.bz2 > As far as I know the comment: > > > -/* enum exp_opcode; ANSI's `wisdom' didn't include forward enum decls. */ > > is right, so you shouldn't have comitted this :(. Perhaps it is now a > GCC extension to allow these, but as far as I remember older versions > of GCC didn't accept this. I thought that we changed the requirement to C90 which should accept this. I was comforted in this direction by the fact that we already use this paradigm elsewhere so I thought it was OK. -- Joel