Re: Overlay support broken (Re: [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap))

Daniel Jacobowitz
2008-05-15T17:03:03Z

On Thu, May 15, 2008 at 06:38:48PM +0200, Ulrich Weigand wrote:
> > > For now, I'm using the patch below that simply falls back to the non-addrmap
> > > case when debugging overlays and the addrmap returned the wrong section.
> >
> > I started coding a similiar patch as IMO the overlayed sections have no use for
> > addrmap as they are not discontiguous, thanks for fixing it up this way.
>
> Hmm, OK. However, even with overlay debugging, there might be some other
> discontiguous sections, so I don't really like the
> if (overlay_debugging ...)
> aspect of my patch. But without that condition, one of your new test cases
> would fail again.

Yes, I don't like that part either. I wonder if the memory usage
would be too bad if we kept an addrmap for each section and one
combined one for the non-overlay case?

I don't know what overlay debug info looks like. Can we detect
overlays in any practical way when reading in symbols?

--
Daniel Jacobowitz
CodeSourcery