From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2316 invoked by alias); 17 Dec 2007 01:49:43 -0000 Received: (qmail 1948 invoked by uid 22791); 17 Dec 2007 01:49:42 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 01:49:37 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lBH1nZAc031195 for ; Sun, 16 Dec 2007 20:49:35 -0500 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lBH1nYIL015779 for ; Sun, 16 Dec 2007 20:49:35 -0500 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id lBH1nXj0029115 for ; Sun, 16 Dec 2007 20:49:34 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.2/8.14.1) with ESMTP id lBH1nWEc014258; Mon, 17 Dec 2007 02:49:32 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.2/8.14.2/Submit) id lBH1nWnK014257; Mon, 17 Dec 2007 02:49:32 +0100 Date: Mon, 17 Dec 2007 02:41:00 -0000 From: Jan Kratochvil To: gdb-patches@sources.redhat.com Cc: Daniel Jacobowitz Subject: Re: [patch] Discontiguous PSYMTABs Message-ID: <20071217014931.GA13530@host0.dyn.jankratochvil.net> References: <20071009181701.GA30757@caradoc.them.org> <20071009185434.GA27810@host0.dyn.jankratochvil.net> <20071009185931.GA1220@caradoc.them.org> <20071124154339.GA14913@host0.dyn.jankratochvil.net> <20071130111021.GA17867@host0.dyn.jankratochvil.net> <20071130145613.GA5941@caradoc.them.org> <20071209203138.GA23339@host0.dyn.jankratochvil.net> <20071217005641.GA14690@caradoc.them.org> <20071217010217.GB14690@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071217010217.GB14690@caradoc.them.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00251.txt.bz2 On Mon, 17 Dec 2007 02:02:17 +0100, Daniel Jacobowitz wrote: > On Sun, Dec 16, 2007 at 07:56:41PM -0500, Daniel Jacobowitz wrote: > > On Sun, Dec 09, 2007 at 09:31:38PM +0100, Jan Kratochvil wrote: > > > Attaching the fix for discontiguous psymtabs based on the addrmap framework. > > > > > > This one is a conservative one - it tries to just fix it with minimal changes. > > > It is bidirectionally compatible: > > > * Producer (dwarf2read.c) still tries to set the bounds TEXTLOW and TEXTHIGH. > > > * Consumer (symtab.c) deals with both set and unset PSYMTABS_ADDRMAP. > > > > This looks OK to me. Thanks for doing it! > > Oops, maybe not. I've just thought of another case where we might > have trouble. What if one file contains DW_AT_ranges and another file > only contains stabs? "file" here is OBJFILE? In such case the patch behaves right - it search each OBJFILE by ALL_OBJFILES separately. If "file" is CU it is IMO not possible to combine multiple debug formats inside one OBJFILE, right? > If we trust the addrmap, will we still find the file with stabs? We > may need to fall through. Existing PSYMTABS_ADDRMAP will catch only the really present addresses, it has no false positives. In other cases it should be IMO backward compatible as it will fallback to the code emulating the old one. Could you please give a more specific counterexample? Thanks, Jan