From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24569 invoked by alias); 16 Dec 2007 21:45:09 -0000 Received: (qmail 24555 invoked by uid 22791); 16 Dec 2007 21:45:09 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Dec 2007 21:45:03 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 1858598129; Sun, 16 Dec 2007 21:45:02 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 9B6609811F; Sun, 16 Dec 2007 21:45:01 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J41IC-00019T-Qq; Sun, 16 Dec 2007 16:45:00 -0500 Date: Sun, 16 Dec 2007 21:48:00 -0000 From: Daniel Jacobowitz To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Watchpoints + conditionals problem Message-ID: <20071216214500.GD2618@caradoc.them.org> Mail-Followup-To: Luis Machado , gdb-patches@sourceware.org References: <1196272755.15925.11.camel@gargoyle> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1196272755.15925.11.camel@gargoyle> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00231.txt.bz2 On Wed, Nov 28, 2007 at 03:59:15PM -0200, Luis Machado wrote: > Index: gdb/breakpoint.c > =================================================================== > --- gdb.orig/breakpoint.c 2007-11-28 09:47:26.000000000 -0800 > +++ gdb/breakpoint.c 2007-11-28 09:49:47.000000000 -0800 > @@ -2969,7 +2969,7 @@ > if (b->type == bp_watchpoint_scope) > b->related_breakpoint->watchpoint_triggered = watch_triggered_yes; > > - if (bl->cond) > + if (bl->cond && bl->owner->disposition != disp_del_at_next_stop) > { > /* Need to select the frame, with all that implies > so that the conditions will have the right context. */ Seems OK to me. -- Daniel Jacobowitz CodeSourcery