From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: delete_breakpoint: don't try to insert other breakpoints
Date: Sun, 16 Dec 2007 21:13:00 -0000 [thread overview]
Message-ID: <20071216205939.GI22905@caradoc.them.org> (raw)
In-Reply-To: <200711142324.11319.vladimir@codesourcery.com>
On Wed, Nov 14, 2007 at 11:24:10PM +0300, Vladimir Prus wrote:
>
> The delete_breakpoint function tries to check if the
> breakpoint being deleted is inserted in inferior, and if
> so, searched for breakpoints that are set at the same address
> and tries to insert them. However, GDB removes breakpoint
> from the inferior immediately when inferior is stopped,
> so this code will never run. Removing this code has
> no effect on test results.
>
> (And generally, if that function needed to insert breakpoints,
> it should have used insert_breakpoints, instead of duplicating
> the logic somewhat).
>
> OK?
I believe that another version of this patch, which replaces the wrong
code with more useful behavior, is part of your keep breakpoints
inserted RFC, so this patch is withdrawn. Let me know if I'm
wrong :-)
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2007-12-16 20:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 20:24 Vladimir Prus
2007-11-15 4:04 ` Eli Zaretskii
2007-11-15 5:59 ` Vladimir Prus
2007-11-16 10:13 ` Eli Zaretskii
2007-11-16 10:34 ` Vladimir Prus
2007-11-16 11:15 ` Eli Zaretskii
2007-11-16 13:02 ` Daniel Jacobowitz
2007-11-16 14:14 ` Vladimir Prus
2007-11-16 15:09 ` Eli Zaretskii
2007-11-16 21:44 ` Nick Roberts
2007-11-16 22:24 ` Vladimir Prus
2007-11-17 9:13 ` Eli Zaretskii
2007-11-18 1:25 ` Nick Roberts
2007-12-16 21:13 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071216205939.GI22905@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox