Re: [RFA] Inform about new thread in a single place.

Mark Kettenis
2007-12-14T19:55:55Z

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Fri, 14 Dec 2007 22:40:20 +0300
>
> > > What about me adding 'add_thread_silent' function that will
> > > not print any message, and using it in bds-uthread.c?
> >
> > That'd be acceptable to me. I'm not absolutely true that none of the
> > modules you mention above don't need this, but we can fix those when
> > we notice the problem.
>
> Here's the revised patch. OK?

I don't think so. Look at the output from debugging a threaded
program and ask yourself if you really have that many new threads ;)

Also, this makes some platforms now print the message, where it didn't
before (for example on win32). Please make sure you get approval from
the relevant maintainers for any changed behaviour.

Cheers,

Mark

> * thread.c (add_thread_silent): Renamed
> from add_thread.
> (add_thread): Announce new thread.
> * gdbthread.h (add_thread_silent): Declare.
> * inf-ttrace.c (inf_ttrace_wait): Don't
> inform about new thread, as add_thread is always
> called too, and will take care of that.
> * infrun.c (handle_inferior_event): Likewise.
> * procfs.c (procfs_wait): Likewise.
> * remote.c (remote_currthread): Likewise.
> * sol-thread.c (sol_thread_wait): Likewise.
> * win32-nat.c (get_win32_debug_event): Likewise.
> * gdb/linux-nat.c (lin_lwp_attach_lwp): Likewise.
> * linux-thread-db.c (attach_thread): Don't inform
> about new thread. This is called only from
> linux-thread-db.c:attach_thread, which will take care.