From: Vladimir Prus <ghost@cs.msu.su>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Pending breakpoints in MI
Date: Fri, 14 Dec 2007 06:27:00 -0000 [thread overview]
Message-ID: <200712140923.21382.ghost@cs.msu.su> (raw)
In-Reply-To: <uodcuwd5q.fsf@gnu.org>
On Thursday 13 December 2007 23:30:25 Eli Zaretskii wrote:
> > From: Vladimir Prus <ghost@cs.msu.su>
> > Date: Thu, 13 Dec 2007 17:42:53 +0300
> >
> > I've done so. Eli, does the manual changes in the attached patch look
> > good to you?
>
> Yes, except for one minor gotcha:
>
> > +If @var{location} cannot be parsed (for example if it
> > +refers to unknown files or functions), create a pending
> > +breakpoint.
>
> It's better to say "... this command creates a pending breakpoint."
>
> Also, please put 2 spaces after the period that ends a sentence.
Thanks, I've adjusted the patch.
Unfortunately, it seems that one of the prerequisite patches is still
not reviewed, but I'll ping that separately.
- Volodya
prev parent reply other threads:[~2007-12-14 6:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 11:12 Vladimir Prus
2007-11-19 20:42 ` Vladimir Prus
2007-11-26 18:03 ` Vladimir Prus
2007-12-05 14:40 ` Vladimir Prus
2007-12-12 19:21 ` Vladimir Prus
2007-12-13 14:44 ` Joel Brobecker
2007-12-13 16:03 ` Vladimir Prus
2007-12-13 16:12 ` Joel Brobecker
2007-12-14 0:11 ` Eli Zaretskii
2007-12-14 6:27 ` Vladimir Prus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712140923.21382.ghost@cs.msu.su \
--to=ghost@cs.msu.su \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox