From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5494 invoked by alias); 11 Dec 2007 18:38:57 -0000 Received: (qmail 5486 invoked by uid 22791); 11 Dec 2007 18:38:57 -0000 X-Spam-Check-By: sourceware.org Received: from pauline.vellum.cz (HELO pauline.vellum.cz) (89.250.243.234) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Dec 2007 18:38:53 +0000 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by pauline.vellum.cz (8.12.11.20060308/8.12.11) with ESMTP id lBBIclhM026918; Tue, 11 Dec 2007 19:38:48 +0100 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.2/8.14.1) with ESMTP id lBBIclmw017736; Tue, 11 Dec 2007 19:38:47 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.2/8.14.2/Submit) id lBBIckGR017735; Tue, 11 Dec 2007 19:38:46 +0100 Date: Wed, 12 Dec 2007 16:26:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Daniel Jacobowitz Subject: Re: [patch] fileio.exp FAILs if run as root Message-ID: <20071211183846.GA15795@host0.dyn.jankratochvil.net> References: <20071208181422.GA10275@host0.dyn.jankratochvil.net> <200712081858.lB8Iw5pn014666@brahms.sibelius.xs4all.nl> <20071208191320.GA11395@host0.dyn.jankratochvil.net> <1197393212.32169.63.camel@localhost.localdomain> <20071211174626.GA15092@host0.dyn.jankratochvil.net> <20071211175423.GA8014@caradoc.them.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="5vNYLRcllDrimb99" Content-Disposition: inline In-Reply-To: <20071211175423.GA8014@caradoc.them.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00163.txt.bz2 --5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 232 On Tue, 11 Dec 2007 18:54:23 +0100, Daniel Jacobowitz wrote: ... > I think a warning is quite sufficient. Perhaps in the FAIL message. Attached. Still there is an XFAIL for Cygwin so it IMO could be even for UNIX. Regards, Jan --5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="gdb-cvs-test-fileio-root-run2.patch" Content-length: 1358 2007-12-11 Jan Kratochvil * gdb.base/fileio.exp: Add the testcase purpose comment at the top. Embed a warning into the name of two testcases known to fail if we run as root. --- ./gdb/testsuite/gdb.base/fileio.exp 23 Aug 2007 18:14:16 -0000 1.12 +++ ./gdb/testsuite/gdb.base/fileio.exp 11 Dec 2007 18:22:44 -0000 @@ -17,6 +17,8 @@ # bug-gdb@prep.ai.mit.edu # This file was written by Corinna Vinschen +# Its main purpose is to test the GDB implementation of the remote file I/O +# protocol. if [target_info exists gdb,nofileio] { verbose "Skipping fileio.exp because of no fileio capabilities." @@ -92,7 +94,7 @@ catch "system \"chmod -f -w nowrt.fileio gdb_test continue \ "Continuing\\..*open 5:.*EACCES$stop_msg" \ -"Open for write but no write permission returns EACCES" +"Open for write but no write permission returns EACCES (it also fails if running as root)" gdb_test continue \ "Continuing\\..*write 1:.*OK$stop_msg" \ @@ -234,7 +236,7 @@ if [ishost *cygwin*] { } gdb_test continue \ "Continuing\\..*unlink 2:.*EACCES$stop_msg" \ -"Unlinking a file in a directory w/o write access returns EACCES" +"Unlinking a file in a directory w/o write access returns EACCES (it also fails if running as root)" gdb_test continue \ "Continuing\\..*unlink 3:.*ENOENT$stop_msg" \ --5vNYLRcllDrimb99--