From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30193 invoked by alias); 10 Dec 2007 00:21:01 -0000 Received: (qmail 30185 invoked by uid 22791); 10 Dec 2007 00:21:00 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Dec 2007 00:20:56 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lBA0KsWg007492 for ; Sun, 9 Dec 2007 19:20:54 -0500 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lBA0KrNe004605 for ; Sun, 9 Dec 2007 19:20:54 -0500 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id lBA0KpkY017931 for ; Sun, 9 Dec 2007 19:20:52 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.2/8.14.1) with ESMTP id lBA0KpMv000576 for ; Mon, 10 Dec 2007 01:20:51 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.2/8.14.2/Submit) id lBA0Kp4c000575 for gdb-patches@sources.redhat.com; Mon, 10 Dec 2007 01:20:51 +0100 Date: Mon, 10 Dec 2007 14:07:00 -0000 From: Jan Kratochvil To: gdb-patches@sources.redhat.com Subject: [patch] Fix sepdebug.exp build-id occasional FAILs Message-ID: <20071210002051.GA506@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="yrj/dFKFPuw6o+aM" Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00146.txt.bz2 --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 653 Hi, a bug in my own code - a forgotten binary type, I should learn better Tcl. It FAILs only for specific deterministically-random build-id hashes, this one 4edd6ca0c5be6b98d27ae5f0b31bbfe782ebd2aa was read incorrectly as 4edd6ca07e6b98d27ae5f0b31bbfe782ebaa resulting in FAIL: build-id: breakpoint function, optimized file FAIL: build-id: breakpoint small function, optimized file FAIL: build-id: run until function breakpoint, optimized file FAIL: build-id: run until function breakpoint, optimized file FAIL: build-id: run until breakpoint set at small function, optimized file Approval requested although the fix is obvious. Sorry, Jan --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="gdb-cvs-build_id_debug_filename_get-binary.patch" Content-length: 491 2007-12-09 Jan Kratochvil * lib/gdb.exp (build_id_debug_filename_get): OBJCOPY pipe being read must be set to binary. --- ./gdb/testsuite/lib/gdb.exp 9 Dec 2007 11:21:21 -0000 1.93 +++ ./gdb/testsuite/lib/gdb.exp 10 Dec 2007 00:14:55 -0000 @@ -2500,6 +2500,7 @@ proc build_id_debug_filename_get { exec return "" } set fi [open $tmp] + fconfigure $fi -translation binary # Skip the NOTE header. read $fi 16 set data [read $fi] --yrj/dFKFPuw6o+aM--