From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4196 invoked by alias); 2 Dec 2007 02:43:17 -0000 Received: (qmail 4187 invoked by uid 22791); 2 Dec 2007 02:43:17 -0000 X-Spam-Check-By: sourceware.org Received: from pool-70-20-17-24.bstnma.fios.verizon.net (HELO ednor.cgf.cx) (70.20.17.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Dec 2007 02:43:12 +0000 Received: by ednor.cgf.cx (Postfix, from userid 201) id 1D71F2B352; Sat, 1 Dec 2007 21:43:11 -0500 (EST) Date: Sun, 02 Dec 2007 02:43:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Pierre Muller Subject: Re: [RFA v2] Allow cygwin native to compile with --enable-64-bit-bfd Message-ID: <20071202024311.GB15745@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Pierre Muller References: <000001c82dad$e507e0b0$af17a210$@u-strasbg.fr> <20071124210708.GE4928@ednor.casa.cgf.cx> <20071124224727.GA13580@caradoc.them.org> <20071125173207.GA7689@ednor.casa.cgf.cx> <20071125190823.GA11606@caradoc.them.org> <20071125221238.GB10356@ednor.casa.cgf.cx> <000901c83270$2a7f7060$7f7e5120$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000901c83270$2a7f7060$7f7e5120$@u-strasbg.fr> User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00028.txt.bz2 On Thu, Nov 29, 2007 at 11:11:11AM +0100, Pierre Muller wrote: >> >> And the warning is? >> > >> >Cast from pointer to integer of different size. Casts are the way >> >we've handled it elsewhere in GDB, but I wouldn't complain about a >> >wrapper; casting host pointers to CORE_ADDRs is an action we try to >> >keep to a minimum anyway. >> >> I wouldn't mind a double cast either, if there is precedent for that. > > Here is a revised patch that only uses double typecasts. > I ran the testsuite and got a slight improvement (2 FAIL less in >gdb.base/signals.exp), >but I doubt this is significant... > >OK to check in? I'd like to get opinions from other maintainers on the use of a macro for this case. I don't like seeing unexplained double casts like this and I think a macro could make it clearer. Daniel were you implying that you would just tolerate a macro here or do you think it's an ok idea. cgf >ChangeLog entry: > >2007-11-28 Pierre Muller > > *win32-nat.c: Allow compilation if CORE_ADDR is 8 byte long. > Add "gdb_stdint.h" dependency required for uintptr_t type use. > (handle_output_debug_string): Use uintptr_t typecast. > (handle_exception): Ditto. > (win32_xfer_memory): Ditto.