From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 856 invoked by alias); 1 Dec 2007 18:53:46 -0000 Received: (qmail 845 invoked by uid 22791); 1 Dec 2007 18:53:45 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 01 Dec 2007 18:53:39 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0B53798249; Sat, 1 Dec 2007 18:53:38 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id EA88D98248; Sat, 1 Dec 2007 18:53:37 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IyXT7-0006NZ-5D; Sat, 01 Dec 2007 13:53:37 -0500 Date: Sat, 01 Dec 2007 18:53:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org, Lerele Subject: Re: [gdbserver/win32] (3/11) Fix suspend count handling Message-ID: <20071201185337.GB24231@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org, Lerele References: <4737B543.80607@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4737B543.80607@portugalmail.pt> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00017.txt.bz2 On Mon, Nov 12, 2007 at 02:06:59AM +0000, Pedro Alves wrote: > I have yet to turn this into a proper gdb test. Is that wanted? Where > shall I put it? gdb.base? gdb.thread? other? gdb.threads would be good, I think. > 2007-11-12 Leo Zayas > Pedro Alves > > * win32-low.h (win32_thread_info): Add descriptions to the > structure members . Replace `suspend_count' counter by a > `suspended' flag. > > * win32-low.c (thread_rec): Update condition of when to get the > context from the inferior. Rely on ContextFlags being set if it > has already been retrieved. Only suspend the inferior thread if > we haven't already. Warn if that fails. > (continue_one_thread): s/suspend_count/suspended/. Only call > ResumeThread once. Warn if that fails. OK. -- Daniel Jacobowitz CodeSourcery