From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6790 invoked by alias); 30 Nov 2007 23:00:59 -0000 Received: (qmail 6778 invoked by uid 22791); 30 Nov 2007 23:00:58 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 30 Nov 2007 23:00:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id AD2FB9824A; Fri, 30 Nov 2007 23:00:46 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 9681898248; Fri, 30 Nov 2007 23:00:46 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IyEqj-0006T1-K3; Fri, 30 Nov 2007 18:00:45 -0500 Date: Fri, 30 Nov 2007 23:00:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sourceware.org Subject: Re: RFA: Fix check for no-saved-pc Message-ID: <20071130230045.GA24809@caradoc.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sourceware.org References: <1196462431.2501.164.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1196462431.2501.164.camel@localhost.localdomain> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00573.txt.bz2 On Fri, Nov 30, 2007 at 02:40:31PM -0800, Michael Snyder wrote: > There's a check in get_prev_frame to see if the next saved pc > is zero. I think it has an off-by-one error, and is checking > for the pc of the wrong frame. Mark K. and I have had roughly a month's worth of discussion on this check over the last two years; it's where it is on purpose. Here's the last conversation: http://sourceware.org/ml/gdb-patches/2006-05/msg00196.html http://sourceware.org/ml/gdb-patches/2006-07/msg00296.html -- Daniel Jacobowitz CodeSourcery