From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29999 invoked by alias); 28 Nov 2007 22:24:50 -0000 Received: (qmail 29790 invoked by uid 22791); 28 Nov 2007 22:24:48 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Nov 2007 22:24:41 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id lASMOcmr492770 for ; Wed, 28 Nov 2007 22:24:38 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lASMObUj3006524 for ; Wed, 28 Nov 2007 23:24:37 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lASMObKA006229 for ; Wed, 28 Nov 2007 23:24:37 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id lASMOb40006226; Wed, 28 Nov 2007 23:24:37 +0100 Message-Id: <200711282224.lASMOb40006226@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 28 Nov 2007 23:24:37 +0100 Subject: Re: [RFA] Stop infrun from tracking breakpoint insertion status. To: vladimir@codesourcery.com (Vladimir Prus) Date: Wed, 28 Nov 2007 22:24:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sources.redhat.com In-Reply-To: <200711272155.17999.vladimir@codesourcery.com> from "Vladimir Prus" at Nov 27, 2007 09:55:17 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00532.txt.bz2 Vladimir Prus wrote: > The second problem was that breakpoint_inserted_here_p checks for > both ordinary breakpoints and single step breakpoints (which don't > go on bp_location_chain). In most cases, it does not matter, but > in one place the code tries to figure if we're stopped on a single > step breakpoint or an ordinary one, and surely, breakpoint_inserted_here_p > returning 1 for both cases was not good. > > The attached revision of the patch introduces a separate > regular_breakpoint_inserted_here_p function. No regressions on > either x86 or arm-linux. OK? I've tested this on powerpc-ibm-aix5.3.0.0 as well, no regressions. > * breakpoint.h (regular_breakpoint_inserted_here_p): New > declaration. > * breakpoint.c (regular_breakpoint_inserted_here_p): New. > (breakpoint_inserted_here_p): Use > regular_breakpoint_inserted_here_p. > * infrun.c (breakpoints_inserted): Remove. > (resume): Don't check for breakpoints_inserted before > remove_hw_watchpoints. Use breakpoint_inserted_here_p. > (proceed, init_wait_for_inferior): Don't set breakpoints_inserted. > (handle_inferior_event): Don't use breakpoints_inserted. > Use breakpoints_meant_to_be_inserted and > breakpoints_inserted_here_p. > (insert_step_resume_breakpoint_at_sal, keep_going): Use > breakpoints_meant_to_be_inserted. Don't set breakpoints_inserted. > (normal_stop): Don't check for breakpoints_inserted. Don't > set breakpoints_inserted. > (keep_going): Don't check for breakpoints_inserted. > (insert_step_resume_breakpoint_at_sal): Don't insert > breakpoints This is OK. > /* Remove breakpoints, SOLIB_ADD might adjust > breakpoint addresses via breakpoint_re_set. */ > - breakpoints_were_inserted = breakpoints_inserted; "breakpoints_were_inserted" is now unused, could you please remove the variable definition as well? Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com