From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30434 invoked by alias); 27 Nov 2007 17:49:55 -0000 Received: (qmail 30425 invoked by uid 22791); 27 Nov 2007 17:49:55 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Nov 2007 17:49:51 +0000 Received: (qmail 17784 invoked from network); 27 Nov 2007 17:49:49 -0000 Received: from unknown (HELO wind.local) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Nov 2007 17:49:49 -0000 From: Vladimir Prus To: "Ulrich Weigand" Subject: Re: [RFA] Stop infrun from tracking breakpoint insertion status. Date: Tue, 27 Nov 2007 17:49:00 -0000 User-Agent: KMail/1.9.6 Cc: gdb-patches@sources.redhat.com References: <200711261524.lAQFOu2E025275@d12av02.megacenter.de.ibm.com> In-Reply-To: <200711261524.lAQFOu2E025275@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200711272049.42766.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00511.txt.bz2 On Monday 26 November 2007 18:24:56 Ulrich Weigand wrote: > Vladimir Prus wrote: > > > On Thursday 22 November 2007 03:49:22 you wrote: > > > Hmmm, if it helps, I could run a test on AIX, which does use > > > TARGET_WAITKIND_LOADED. > > > > That would surely help in convincing ourself the patch don't > > break anything. > > I did a test run on AIX now, and unfortunately it did break. > > I didn't look into the failure in detail, but apparently it > is unrelated to TARGET_WAITKIND_LOADED, but rather to software > single-step support: There were in fact two distinct problems. The first was in my previous patch to document infrun logic -- while the patch was meant to have no logic change, the case of stepping over breakpoint using software single step was messed up. This patch fixes the problem -- it was tested on arm-linux/qemu, which uses software single step, with no test result changes. OK? - Volodya * infrun.c (resume): Set right thread even if stepping over breakpoint using software single step. --- gdb/infrun.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index 85d889a..00cd2a5 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -605,7 +605,8 @@ a command like `return' or `jump' to continue execution.")); resume_ptid = inferior_ptid; } - if (step && breakpoint_here_p (read_pc ()) + if ((step || singlestep_breakpoints_inserted_p) + && breakpoint_here_p (read_pc ()) && !breakpoint_inserted_here_p (read_pc ())) { /* We're stepping, have breakpoint at PC, and it's -- 1.5.3.5