From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17585 invoked by alias); 27 Nov 2007 10:45:07 -0000 Received: (qmail 17576 invoked by uid 22791); 27 Nov 2007 10:45:06 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Nov 2007 10:45:01 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1Iwxvt-0003jf-Qd for gdb-patches@sources.redhat.com; Tue, 27 Nov 2007 13:44:57 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1Iwxvk-0003jF-A3; Tue, 27 Nov 2007 13:44:40 +0300 From: Vladimir Prus To: Nick Roberts Subject: Re: [ob] unbreak MI Date: Tue, 27 Nov 2007 10:45:00 -0000 User-Agent: KMail/1.9.6 Cc: gdb-patches@sources.redhat.com References: <200708312244.58216.ghost@cs.msu.su> <200711271000.06151.ghost@cs.msu.su> <18251.62038.407960.47103@kahikatea.snap.net.nz> In-Reply-To: <18251.62038.407960.47103@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711271344.37454.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00507.txt.bz2 On Tuesday 27 November 2007 13:32:54 Nick Roberts wrote: > > > > Probably: > > > > > > > > if (!gdb_type) > > > > ui_out_field_string (uiout, "value", ""); > > > > else if (mi_print_value_p (gdb_type, print_values)) > > > > ui_out_field_string (uiout, "value", varobj_get_value (var)); > > > > > > > > is the right logic? > > > > > > It's probably the right logic, but it seems to cure the symptom rather > > > than the cause. > > Looking again, I see it's not the right logic. GDB will print a value="" > field even for "--no-values" when gdb_type is NULL. > > >... > > The original code, in fact, was in error too, because of this: > > > > return (TYPE_CODE (type) != TYPE_CODE_ARRAY > > && TYPE_CODE (type) != TYPE_CODE_STRUCT > > && TYPE_CODE (type) != TYPE_CODE_UNION); > > > > This will crash if 'type' is NULL. Testsuite fails to detect this because > > presently type is NULL only for C++ pseudo-fields ('public'/'private') and > > the code above is only executed for --simple-values. > > I never use, and never wanted, "-var-list-children --simple-values". And? You keep on making this argument in various context, and I find it wrong. It does not matter if you, or I, make use of a feature -- the code that can segfault on a usage documented in gdb manual should either be removed, or fixed. > > Does this clarify things? > > Yes, thanks. I think the patch below should cover all cases. As far as I'm concerned, it's fine. - Volodya