From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4447 invoked by alias); 26 Nov 2007 13:26:48 -0000 Received: (qmail 4439 invoked by uid 22791); 26 Nov 2007 13:26:47 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 26 Nov 2007 13:26:37 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 8715698349; Mon, 26 Nov 2007 13:26:35 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 62004980A7; Mon, 26 Nov 2007 13:26:35 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1Iwdys-0001mk-6k; Mon, 26 Nov 2007 08:26:34 -0500 Date: Mon, 26 Nov 2007 13:26:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] XLF Fortran: Remove an inappropriate complaint Message-ID: <20071126132634.GA6265@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sources.redhat.com References: <4741A077.9050900@linux.vnet.ibm.com> <20071123015957.GA3202@host0.dyn.jankratochvil.net> <20071123021120.GA11797@host0.dyn.jankratochvil.net> <20071123163125.GA23275@host0.dyn.jankratochvil.net> <4747086C.3070100@linux.vnet.ibm.com> <20071123172104.GA23776@host0.dyn.jankratochvil.net> <20071125145555.GB30778@caradoc.them.org> <20071125221037.GA6297@host0.dyn.jankratochvil.net> <20071125221357.GA20375@caradoc.them.org> <20071126072041.GA16110@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071126072041.GA16110@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00482.txt.bz2 On Mon, Nov 26, 2007 at 08:20:41AM +0100, Jan Kratochvil wrote: > Therefore GDB violates the DWARF3 spec and the complaint there is right as it > warns the user GDB has violated the DWARF3 spec while parsing the ELF file. OK, I see now. But it will complain about the type anyway: complaint (&symfile_complaints, _("Attribute value is not a constant (%s)"), dwarf_form_name (attr->form)); I have no preference - the patch is OK, leaving the complaint is also OK with me. -- Daniel Jacobowitz CodeSourcery