From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26015 invoked by alias); 15 Nov 2007 14:10:00 -0000 Received: (qmail 26007 invoked by uid 22791); 15 Nov 2007 14:09:59 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 15 Nov 2007 14:09:57 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id lAFE9ska111608 for ; Thu, 15 Nov 2007 14:09:54 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.6) with ESMTP id lAFE9scP2326734 for ; Thu, 15 Nov 2007 15:09:54 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lAFE9rLm009230 for ; Thu, 15 Nov 2007 15:09:53 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id lAFE9rnp009225; Thu, 15 Nov 2007 15:09:53 +0100 Message-Id: <200711151409.lAFE9rnp009225@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 15 Nov 2007 15:09:53 +0100 Subject: Re: [rfc] [03/05] Get rid of current_gdbarch in register_sim_regno To: deuling@de.ibm.com (Markus Deuling) Date: Thu, 15 Nov 2007 14:10:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <473AB3E4.3090209@de.ibm.com> from "Markus Deuling" at Nov 14, 2007 09:37:56 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00309.txt.bz2 Markus Deuling wrote: > Ulrich Weigand schrieb: > > Markus Deuling wrote: > > > Those changes are OK, but you should at the same time > > add the gdbarch parameter to the one2one_register_sim_regno > > routine, since this is intended as a routine that can be > > used as argument to gdbarch_set_register_sim_regno. > > > > In fact, it would be good if you could also change the > > *callers* of gdbarch_register_sim_regno to make sure > > they really all have a gdbarch available. > > > > Hi Uli, > > sorry for the delay. Please see my patch: http://sourceware.org/ml/gdb-patches/2007-11/msg00263.html > > The update of that callers is part of that trivial replacement patch. I hope this is ok? OK, thanks. In that case, the original register_sim_regno patch is OK; please also update the one2one_register_sim_regno routine. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com