From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5322 invoked by alias); 14 Nov 2007 11:58:25 -0000 Received: (qmail 5312 invoked by uid 22791); 14 Nov 2007 11:58:25 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 Nov 2007 11:58:21 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1IsGsj-00025F-QN for gdb-patches@sources.redhat.com; Wed, 14 Nov 2007 14:58:14 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1IsGsV-00024H-J5; Wed, 14 Nov 2007 14:57:55 +0300 From: Vladimir Prus To: Nick Roberts Subject: Re: [8/9] multiple locations Date: Wed, 14 Nov 2007 11:58:00 -0000 User-Agent: KMail/1.9.6 References: <18233.20228.172834.464875@kahikatea.snap.net.nz> <18234.40538.721148.831465@kahikatea.snap.net.nz> In-Reply-To: <18234.40538.721148.831465@kahikatea.snap.net.nz> Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711141047.03166.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00266.txt.bz2 On Wednesday 14 November 2007 10:06:02 you wrote: > > As I say in another email, I might be able to implement using > > as address in all cases. > > I don't pretend to understand the code but the patch below seems to work > for me (probably not all cases). I believe that in a case of breakpoint with multiple locations, where the first location is shlib_disabled, the updated code will print as address, not . I think the right approach would be moving the check for loc->shlib_disabled later, like this: if (b->loc == NULL) ui_out_field_string (uiout, "addr", ""); else if (header_of_multiple) ui_out_field_string (uiout, "addr", ""); else if (loc->shlib_disabled) ui_out_field_string (uiout, "addr", ""); else ui_out_field_core_addr (uiout, "addr", loc->address); But there's also testsuite to be updated and getting somebody to actually approve this patch. > > But generally, trying to keeping CLI back compatible have to stop > > at some time -- if we keep this "don't break CLI clients even if > > CLI clients were deprecated from some time" attitude, it will result > > in new features being available via MI only. > > Focussing on the issue at hand, we're just talking about making a minor > adjustment to the format of "info breakpoints", for the case of pending > breakpoints, to avoid breaking existing frontend(s). Not quite. We're trying to please frontend(s) using deprecated protocol. However little time is spent on that, it's time not spent on other, better things. Is there a reason Emacs website cannot say "Use MI support, available at http://..."? - Volodya