From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25199 invoked by alias); 8 Nov 2007 21:37:36 -0000 Received: (qmail 25190 invoked by uid 22791); 8 Nov 2007 21:37:35 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Nov 2007 21:37:32 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id lA8LbTnK293800 for ; Thu, 8 Nov 2007 21:37:29 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.6) with ESMTP id lA8LbTiI2256978 for ; Thu, 8 Nov 2007 22:37:29 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lA8LbTZ3020695 for ; Thu, 8 Nov 2007 22:37:29 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id lA8LbTlX020692; Thu, 8 Nov 2007 22:37:29 +0100 Message-Id: <200711082137.lA8LbTlX020692@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 8 Nov 2007 22:37:29 +0100 Subject: Re: [rfc] [03/05] Get rid of current_gdbarch in register_sim_regno To: deuling@de.ibm.com (Markus Deuling) Date: Thu, 08 Nov 2007 21:37:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <47319D49.6000201@de.ibm.com> from "Markus Deuling" at Nov 07, 2007 12:11:05 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00180.txt.bz2 Markus Deuling wrote: > * gdbarch.sh (register_sim_regno): Add gdbarch as parameter. > * gdbarch.{c,h}: Regenerate. > > * arch-utils.h (legacy_register_sim_regno): Add gdbarch as parameter. > * score-tdep.c (score_register_sim_regno): Likewise. > > * arch-utils.c (legacy_register_sim_regno): Add gdbarch as parameter. > Replace current_gdbarch by gdbarch. > * sh-tdep.c (sh_sh2a_register_sim_regno) > (sh_dsp_register_sim_regno): Likewise. > * rs6000-tdep.c (rs6000_register_sim_regno): Likewise. > * mips-tdep.c (mips_register_sim_regno): Likewise. > * m32c-tdep.c (m32c_register_sim_regno): Likewise. > * frv-tdep.c (frv_register_sim_regno): Likewise. > * arm-tdep.c (arm_register_sim_regno): Likewise. Those changes are OK, but you should at the same time add the gdbarch parameter to the one2one_register_sim_regno routine, since this is intended as a routine that can be used as argument to gdbarch_set_register_sim_regno. In fact, it would be good if you could also change the *callers* of gdbarch_register_sim_regno to make sure they really all have a gdbarch available. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com