From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: gdb-patches@sourceware.org,
Mark Kettenis <mark.kettenis@xs4all.nl>,
Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] [02/05] Get rid of current_gdbarch in hppa-linux-nat.c
Date: Wed, 07 Nov 2007 15:06:00 -0000 [thread overview]
Message-ID: <20071107150623.GB20821@caradoc.them.org> (raw)
In-Reply-To: <4731D0B9.8000809@de.ibm.com>
On Wed, Nov 07, 2007 at 03:50:33PM +0100, Markus Deuling wrote:
> What this patch does is transform
>
> if ((unsigned) regno >= gdbarch_num_regs (current_gdbarch))
> error (_("Invalid register number %d."), regno);
>
>
> into
>
> if ((unsigned) regno >= gdbarch_num_regs (gdbarch))
> error (_("Invalid register number %d."), regno);
>
>
> The gdbarch comes from regcache in {fetch,store}_register. Why is that wrong ?
Again, it is not necessary to add a gdbarch parameter here. Why are
we checking regno? We're checking it because we're about to use it to
index into the u_offsets array, and we don't want to go out of bounds.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-11-07 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 11:12 Markus Deuling
2007-11-07 11:31 ` Mark Kettenis
2007-11-07 11:51 ` Markus Deuling
2007-11-07 12:58 ` Daniel Jacobowitz
2007-11-07 14:52 ` Markus Deuling
2007-11-07 15:06 ` Daniel Jacobowitz [this message]
2007-11-08 21:31 ` Ulrich Weigand
2007-11-07 13:16 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071107150623.GB20821@caradoc.them.org \
--to=drow@false.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox