From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] [01/05] Get rid of current_gdbarch in gdbarch.{c,h,sh}
Date: Wed, 07 Nov 2007 15:05:00 -0000 [thread overview]
Message-ID: <20071107150457.GA20821@caradoc.them.org> (raw)
In-Reply-To: <4731D20A.7020506@de.ibm.com>
On Wed, Nov 07, 2007 at 03:56:10PM +0100, Markus Deuling wrote:
> Daniel Jacobowitz schrieb:
> > On Wed, Nov 07, 2007 at 12:11:00PM +0100, Markus Deuling wrote:
> >> architecture. This ensures that the new architectures initial
> >> values are not influenced by the previous architecture. Once
> >> everything is parameterised with gdbarch, this will go away. */
> >> - struct gdbarch *current_gdbarch;
> >> + struct gdbarch *gdbarch;
> > Please read the comment above this variable :-)
>
> Hm,
> will gdbarch_alloc go away? I thought every target uses gdbarch_alloc to
> allocate a basic
> gdbarch structure and then it overwrites every necessary callback to fit to its
> architecture.
/* NOTE: The new architecture variable is named \`\`current_gdbarch''
so that macros such as TARGET_ARCHITECTURE, when expanded, refer to
the current local architecture and not the previous global
architecture. This ensures that the new architectures initial
values are not influenced by the previous architecture. Once
everything is parameterised with gdbarch, this will go away. */
struct gdbarch *current_gdbarch;
"this will go away" refers to "is named current_gdbarch".
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-11-07 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 11:13 Markus Deuling
2007-11-07 12:59 ` Daniel Jacobowitz
2007-11-07 14:58 ` Markus Deuling
2007-11-07 15:05 ` Daniel Jacobowitz [this message]
2007-11-08 13:18 ` Ulrich Weigand
2007-11-09 7:30 ` Markus Deuling
2007-11-09 13:19 ` Ulrich Weigand
2007-11-12 6:48 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071107150457.GA20821@caradoc.them.org \
--to=drow@false.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox