From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org,
amodra@bigpond.net.au
Subject: Re: [rfc, v2] Fix ELF synthetic symbol size bug (affects PPC64)
Date: Tue, 06 Nov 2007 21:44:00 -0000 [thread overview]
Message-ID: <20071106214402.GA18867@caradoc.them.org> (raw)
In-Reply-To: <200711062133.lA6LX4nq031372@d12av02.megacenter.de.ibm.com>
On Tue, Nov 06, 2007 at 10:33:04PM +0100, Ulrich Weigand wrote:
> Alan suggested a way to pass that information: have the udata.p
> member of the synthetic symbol point back to the full ELF symbol
> structure of the original symbol used to derive the synthetic
> symbol from. The patch below implements this.
>
> Tested (GDB) on powerpc64-linux, fixes another 12 FAILs on top
> of the ones already fixed by the original patch.
>
> Is the bfd part OK?
The elf.c part of this does not make sense to me. Why should we have
the same size as that symbol? The @plt entry is only a couple of
instructions. To figure out its size you need to ask the backend
plt_sym_val routine.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2007-11-06 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 20:14 [rfc] " Ulrich Weigand
2007-11-05 20:22 ` Daniel Jacobowitz
2007-11-06 21:33 ` [rfc, v2] " Ulrich Weigand
2007-11-06 21:44 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106214402.GA18867@caradoc.them.org \
--to=drow@false.org \
--cc=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox