From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51961-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23989 invoked by alias); 5 Nov 2007 13:44:53 -0000
Received: (qmail 23978 invoked by uid 22791); 5 Nov 2007 13:44:53 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Nov 2007 13:44:50 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.0) with ESMTP id lA5DhT2o028760; 	Mon, 5 Nov 2007 14:43:29 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id lA5DhTWq006451; 	Mon, 5 Nov 2007 14:43:29 +0100 (CET)
Date: Mon, 05 Nov 2007 13:44:00 -0000
Message-Id: <200711051343.lA5DhTWq006451@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: deuling@de.ibm.com
CC: gdb-patches@sourceware.org, uweigand@de.ibm.com
In-reply-to: <472F0AC9.7030700@de.ibm.com> (message from Markus Deuling on 	Mon, 05 Nov 2007 13:21:29 +0100)
Subject: Re: [rfc] [04/09] Get rid of current_gdbarch  (SIZEOF_FRAME_SAVED_REGS  macro)
References:  <472F0AC9.7030700@de.ibm.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-11/txt/msg00057.txt.bz2

> Date: Mon, 05 Nov 2007 13:21:29 +0100
> From: Markus Deuling <deuling@de.ibm.com>
> 
> Hi,
> 
> this patch replaces SIZEOF_FRAME_SAVED_REGS macro by its expression.
> 
> Tested by gdb_mbuild with alpha target. Is this ok to commit?

I'm not thrilled, since this replaces a #define that has a sensible
name with some sort of complicated expression, and therefore makes the
code much more difficult to read.

> ChangeLog: 
> 
> 
> 	* alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Replace
> 	SIZEOF_FRAME_SAVED_REGS by its expression. Use get_frame_arch to get at
> 	the current architecture by frame_info.
> 	* alpha-tdep.c (alpha_heuristic_frame_unwind_cache): Likewise.
> 	* frame.h (SIZEOF_FRAME_SAVED_REGS): Remove.