Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: brobecker@adacore.com (Joel Brobecker)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Reducing the use of current_language - some patches
Date: Sun, 04 Nov 2007 17:15:00 -0000	[thread overview]
Message-ID: <200711041715.lA4HF0JL026952@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20071031031711.GM5265@adacore.com> from "Joel Brobecker" at Oct 30, 2007 11:17:11 PM

Joel Brobecker wrote:

> As I said before, the goal of this exercise is to avoid having to play
> with the current language in order to do parsing operations in a language
> that may not be the current language.

This sounds like a good idea, thanks for taking care of it!

Just one suggestion that occurred to me: parsing operations depend
on further global state than just the current language; in particular
they depend on the "input_radix", and also on the currently active
gdbarch (which e.g. modifies language primitive types).

So I was wondering if we shouldn't add just a "language" parameter
to the parsing routines, but something more general, like a "parse
context" structure.  This could encapsulate all that global state,
and would be easily extensible in the future ...

Maybe (if this is a good idea), it could be done after your current
set of patches; on the other hand, as you're touching all those files
anyway, maybe it would be simpler to do it in one go.

What do you think?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2007-11-04 17:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31 10:47 Joel Brobecker
2007-11-04 17:15 ` Ulrich Weigand [this message]
2007-11-05  3:50   ` Joel Brobecker
2007-11-05 13:19     ` Daniel Jacobowitz
2007-11-05 15:25       ` Ulrich Weigand
2007-11-05 17:18         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711041715.lA4HF0JL026952@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox