From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Fix mst_solib_trampoline symbol sections for PLT stubs
Date: Wed, 31 Oct 2007 20:41:00 -0000 [thread overview]
Message-ID: <200710311912.l9VJCD4s012222@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20071031153420.GA7724@caradoc.them.org> from "Daniel Jacobowitz" at Oct 31, 2007 11:34:21 AM
Daniel Jacobowitz wrote:
> Interesting. On most platforms, that's not necessary: LD only needs
> to set a canonical address in the executable's symtab if the
> executable takes the function's address, so this should only happen if
> those non-PIC calls were indistinguishable from taking the address.
>
> That's not implemented for PowerPC. I don't know if it's an ABI
> requirement or just a missing optimization. Search for "st_value = 0"
> in elf32-ppc.c versus elf32-i386.c.
Interesting indeed; on s390 it looks yet again different. I don't know
why this is handled so differently across platforms ...
> So, this won't help everywhere or fix the root cause, but it does seem
> like it would work for PowerPC.
OK, I've committed the patch now. Whenever we do have the canonical
address hint in the undef symbol, we should use it (and the patch
fixes that in any case). On platforms where we don't have those hints,
some other method needs to work (e.g. synthetic symtab).
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2007-10-31 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 2:09 Ulrich Weigand
2007-10-31 3:17 ` Daniel Jacobowitz
2007-10-31 17:56 ` Ulrich Weigand
2007-10-31 18:06 ` Daniel Jacobowitz
2007-10-31 20:41 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710311912.l9VJCD4s012222@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox