From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5713 invoked by alias); 24 Oct 2007 20:10:04 -0000 Received: (qmail 5699 invoked by uid 22791); 24 Oct 2007 20:10:03 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 Oct 2007 20:10:01 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 2C60F98341; Wed, 24 Oct 2007 20:10:00 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id E217C981F2; Wed, 24 Oct 2007 20:09:59 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IkmYA-0004Lq-T9; Wed, 24 Oct 2007 16:09:58 -0400 Date: Wed, 24 Oct 2007 20:11:00 -0000 From: Daniel Jacobowitz To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/4] decimal floating point types Message-ID: <20071024200958.GJ10943@caradoc.them.org> Mail-Followup-To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20070920215410.062714003@br.ibm.com> <20070920215539.651720008@br.ibm.com> <20071011155721.GB22982@caradoc.them.org> <1192471909.5787.45.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1192471909.5787.45.camel@localhost.localdomain> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00617.txt.bz2 On Mon, Oct 15, 2007 at 04:11:49PM -0200, Thiago Jung Bauermann wrote: > 2007-10-15 Wu Zhou > Thiago Jung Bauermann > > * c-lang.c (c_create_fundamental_type): Create fundamental > types for DFP. > * c-typeprint.c (c_type_print_varspec_prefix): Add > TYPE_CODE_DECFLOAT to no prefix needed case. > (c_type_print_varspec_suffix): Add TYPE_CODE_DECFLOAT to no > suffix needed case. > * c-valprint.c (c_val_print): Call print_decimal_floating to > print DFP values. > * dwarf2read.c (read_base_type): Read DW_ATE_decimal_float > attribute code and return TYPE_CODE_DECFLOAT. > (dwarf_base_type): Set dwarf2_fundamental_type for DFP values. > * gdbtypes.c (gdbtypes_post_init): Initialize builtin_decfloat, > builtin_decdouble and builtin_declong. > * gdbtypes.h (enum type_code): Add TYPE_CODE_DECFLOAT as a > type code for DFP. > (FT_DECFLOAT, FT_DBL_PREC_DECFLOAT, FT_EXT_PREC_DECFLOAT): New > types, for decimal floating point. > (FT_NUM_MEMBERS): Increment, new types added. > (struct builtin_type): Add builtin_decfloat, builtin_decdouble > and builtin_declong. > * valprint.c (print_decimal_floating): New function to print DFP > values. > * value.h (print_decimal_floating): Prototype. This version looks good to me. -- Daniel Jacobowitz CodeSourcery