Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] win32-nat.c: Handle EXCEPTION_INVALID_HANDLE as SIGSYS
Date: Tue, 23 Oct 2007 22:26:00 -0000	[thread overview]
Message-ID: <20071023221831.GA10058@caradoc.them.org> (raw)
In-Reply-To: <20071023214730.GB5570@ednor.casa.cgf.cx>

On Tue, Oct 23, 2007 at 05:47:30PM -0400, Christopher Faylor wrote:
> So if I got this wrong and closed some handles that shouldn't have been
> closed why doesn't this patch just get rid of those cases?

If I've got this right - and I'm not sure I do - then the patch does
two things.  It stops closing some handles we shouldn't close, and it
adds a new feature which is useful for debugging native Windows
programs which close handles they shouldn't close (or do other bad
things).

If that's right, let's break it up into two please.  Nothing sets
old_behavior, so it's not needed - either the closes are necessary
or they aren't and I suspect most or all Windows versions will be
consistent about which it is.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-10-23 22:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-22 14:14 Pierre Muller
2007-10-22 21:15 ` Eli Zaretskii
2007-10-23 22:06 ` Christopher Faylor
2007-10-23 22:26   ` Daniel Jacobowitz [this message]
2007-10-24  5:21   ` Eli Zaretskii
2007-10-24  8:40     ` Pierre Muller
2007-10-24 19:07       ` Eli Zaretskii
2007-10-24 11:47     ` Pedro Alves
2007-10-24  8:13   ` Pierre Muller
2007-10-24  8:51     ` Pedro Alves
2007-10-24 19:19       ` Eli Zaretskii
2007-10-24 19:37         ` Mark Kettenis
2007-10-24 19:40         ` Daniel Jacobowitz
2007-10-24 20:15           ` Eli Zaretskii
2007-10-29  8:25           ` Christopher Faylor
2007-10-29  3:07       ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071023221831.GA10058@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox