Re: [PATCH] CRIS sim and it's testsuite

["Edgar E. Iglesias" <edgar.iglesias@axis.com>]

On Mon, Oct 22, 2007 at 06:53:39PM +0200, Hans-Peter Nilsson wrote:
> > Date: Wed, 3 Oct 2007 16:58:48 +0200
> > From: "Edgar E. Iglesias" <edgar@axis.com>
> 
> > I noticed that the condition code flags were not tested for
> > move-like insns on CRIS.
> 
> Thanks for looking into this.  Yes, the test_move_cc macro was
> totally fudged.  I can only guess I stubbed it and meant to
> revisit that part but just forgot.
> 
> Your change adds code to just test N and Z though the intention
> of test_move_cc is to also test C and V, for pre-v32.  When
> fixing that, I had to adjust the jsr testcase as seen.  I also
> noticed that there were more flaws in the neg test; the V and C
> flags should always be tested as it's an arithmetic insn and the
> formerly unused/untested values for V and C were wrong.  Noting
> the lack of non-arithmetic V and C tests for v32, I added a new
> test-case to check that V and C aren't affected for v32, for
> some common insns and values.  I'm not claiming full coverage
> there, just better than not testing V and C for v32 at all for
> those insns.

Thanks for taking care of all this H-P.

Best regards
-- 
Edgar E. Iglesias
Axis Communications AB