From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19490 invoked by alias); 16 Oct 2007 13:56:29 -0000 Received: (qmail 19361 invoked by uid 22791); 16 Oct 2007 13:56:27 -0000 X-Spam-Check-By: sourceware.org Received: from pool-70-20-17-24.bstnma.fios.verizon.net (HELO ednor.cgf.cx) (70.20.17.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 16 Oct 2007 13:56:22 +0000 Received: by ednor.cgf.cx (Postfix, from userid 201) id 931952B353; Tue, 16 Oct 2007 09:56:20 -0400 (EDT) Date: Tue, 16 Oct 2007 14:35:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org Subject: Re: Support of gdb for Windows 64 native systems Message-ID: <20071016135619.GA24389@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org References: <20071014173921.GD11619@ednor.casa.cgf.cx> <471259B2.6050808@portugalmail.pt> <20071014221603.GA13096@ednor.casa.cgf.cx> <20071014222252.GA13023@caradoc.them.org> <20071015184525.GI14543@ednor.casa.cgf.cx> <20071015185451.GA3934@caradoc.them.org> <4713F838.9050104@portugalmail.pt> <20071016042121.GA22246@ednor.casa.cgf.cx> <4053daab0710160053v56c78dael4a8c732c3b7d70d7@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4053daab0710160053v56c78dael4a8c732c3b7d70d7@mail.gmail.com> User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00420.txt.bz2 On Tue, Oct 16, 2007 at 08:53:10AM +0100, Pedro Alves wrote: >On 10/16/07, Christopher Faylor wrote: >> On Tue, Oct 16, 2007 at 06:12:31AM +0200, Eli Zaretskii wrote: >> >> Date: Tue, 16 Oct 2007 00:31:04 +0100 >> >> From: Pedro Alves >> >> >> >> How about the attached? >> > >> >I have one concern: >> > >> >> -#include >> > >> >Why do you unconditionally remove this include? Doesn't the Cygwin >> >build want it? >> >> Actually, I wondered about this too and meant to ask. I assume that it >> isn't really needed? >> > >I did explain it upthread: >" - profs.h isn't needed anymore, since I've implemented cygwin cross-core >support a few weeks ago (in i386-cygwin-tdep.c). The include can be > unconditionally removed." Oops. I missed that. Sorry. Thanks for the (re)explanation. I approve this patch. cgf