From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12713 invoked by alias); 15 Oct 2007 14:10:33 -0000 Received: (qmail 12700 invoked by uid 22791); 15 Oct 2007 14:10:31 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 15 Oct 2007 14:10:24 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l9FEALsq648824 for ; Mon, 15 Oct 2007 14:10:21 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9FEALDn1786068 for ; Mon, 15 Oct 2007 16:10:21 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9FEAKBS022681 for ; Mon, 15 Oct 2007 16:10:20 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l9FEAK9F022675; Mon, 15 Oct 2007 16:10:20 +0200 Message-Id: <200710151410.l9FEAK9F022675@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 15 Oct 2007 16:10:20 +0200 Subject: Re: [RFA] gdb_ari.sh patch to eliminate wrong critical errors To: muller@ics.u-strasbg.fr Date: Mon, 15 Oct 2007 14:13:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org ('Daniel Jacobowitz'), gdb-patches@sourceware.org In-Reply-To: <200710151347.l9FDlIOT007227@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Oct 15, 2007 03:47:18 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00386.txt.bz2 I wrote: > (On the other hand, even some functions with count 0 are in > fact still used, because the one use happens to be in a file > that is for some reason excluded from the ARI scan. So you > should double-check for each case you remove that there is > indeed no more reference.) On the other hand, there's also the opposite scenario: in some cases, a function/macro has already been removed, but the ARI still finds apparent uses (which are in fact just occurances of local variable etc. that just happen to have the same name as the removed global construct). I'm aware of at least the following checks that can be removed: supply_register (finds a local struct member) obj_private (finds a local variable) inside_entry_func (find a -now- static function) Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com