From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20739 invoked by alias); 15 Oct 2007 13:47:37 -0000 Received: (qmail 20695 invoked by uid 22791); 15 Oct 2007 13:47:30 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 15 Oct 2007 13:47:22 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l9FDlJlZ514780 for ; Mon, 15 Oct 2007 13:47:19 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9FDlJO21888450 for ; Mon, 15 Oct 2007 15:47:19 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9FDlIGq007231 for ; Mon, 15 Oct 2007 15:47:18 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l9FDlIOT007227; Mon, 15 Oct 2007 15:47:18 +0200 Message-Id: <200710151347.l9FDlIOT007227@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 15 Oct 2007 15:47:18 +0200 Subject: Re: [RFA] gdb_ari.sh patch to eliminate wrong critical errors To: muller@ics.u-strasbg.fr (Pierre Muller) Date: Mon, 15 Oct 2007 13:50:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org ('Daniel Jacobowitz'), gdb-patches@sourceware.org In-Reply-To: <000801c80f0d$3fd4a0b0$bf7de210$@u-strasbg.fr> from "Pierre Muller" at Oct 15, 2007 11:24:55 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00384.txt.bz2 Pierre, > The current ARI page look much better! > Only the inline and hash critical bugs remain. I'm not sure if these categories really make sense ... > To get a ARI page that would better > catch new regression, I could move all > deprecated and obsolete bugs that have > currently a zero count to ari_regression category, > this would trigger them to appear on front, > before the large table if someone reintroduces them. As the comment at the top of gdb_ari.sh, there are two types of checks: # Permenant checks take the form: # Do not use XXXX, ISO C 90 implies YYYY # Do not use XXXX, instead use YYYY''. # and should never be removed. # Temporary checks take the form: # Replace XXXX with YYYY # and once they reach zero, can be eliminated. Only those checks that *can* regress should be moved to the ari_regression category, those that cannot (e.g. use of a function that has actually been removed) should just deleted completely. > There are 6 deprecated functions that have a -1 count. > Which seems to be related to function name appearing in comments > or disabled code. There is some logic that subtracts 2 from the count (to avoid counting the function definition and declaration). This logic gets it wrong in some cases; e.g. it leads to negative values for some functions that have already been completely removed. (On the other hand, even some functions with count 0 are in fact still used, because the one use happens to be in a file that is for some reason excluded from the ARI scan. So you should double-check for each case you remove that there is indeed no more reference.) Thanks for working on clearing up the ARI! Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com