From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9031 invoked by alias); 12 Oct 2007 21:31:45 -0000 Received: (qmail 9021 invoked by uid 22791); 12 Oct 2007 21:31:43 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 12 Oct 2007 21:31:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 033F91E684A; Fri, 12 Oct 2007 17:31:39 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id g3RfRm15pygT; Fri, 12 Oct 2007 17:31:38 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9A8521E6848; Fri, 12 Oct 2007 17:31:38 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5E755E7B58; Fri, 12 Oct 2007 14:31:36 -0700 (PDT) Date: Fri, 12 Oct 2007 21:53:00 -0000 From: Joel Brobecker To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Windows DLL support update (a bit slimmer version) Message-ID: <20071012213136.GG8721@adacore.com> References: <46C8BEC4.3030807@portugalmail.pt> <20070903174605.GK12440@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070903174605.GK12440@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00342.txt.bz2 Daniel, Pedro, > > 2007-08-19 Pedro Alves > > Daniel Jacobowitz > > > > * infcmd.c (post_create_inferior): Update comment. > > (run_command_1): Always call post_create_inferior with 0 as > > from_tty. > > > > * i386-cygwin-tdep.h: New. > > * i386-cygwin-tdep.c: Include "i386-cygwin-tdep.h". > > (win32_xfer_shared_library): Make it extern. > > > > * win32-nat.c: Include gdb_obstack.h and xml-support.h and > > i386-cygwin-tdep.h. > > (win32_so_ops): Delete. > > (get_relocated_section_addrs): Delete. > > (solib_symbols_add): Delete. > > (register_loaded_dll): Delete. > > (win32_make_so): New. > > (handle_load_dll): Use win32_make_so. > > (win32_free_so): Free the passed in so. > > (win32_relocate_section_addresses): Delete. > > (win32_solib_create_inferior_hook): Delete. > > (handle_unload_dll): Don't add PE offset here. Free so with > > win32_free_so instead of free_so. > > (win32_special_symbol_handling): Delete. > > (get_win32_debug_event): Remove unneeded calls. Set state to > > TARGET_WAITKIND_LOADED on a dll unload. > > (do_initial_win32_stuff): Clear cygwin_load_start and > > cygwin_load_end. > > (map_code_section_args): Delete. > > (dll_code_sections_add): Delete. > > (core_section_load_dll_symbols): Delete. > > (win32_xfer_shared_libraries): New. > > (win32_current_sos): Delete. > > (win32_xfer_partial): New. > > (open_symbol_file_object): Delete. > > (in_dynsym_resolve_code): Delete. > > (init_win32_ops): Set win32_xfer_partial as to_xfer_partial member > > of win32_ops. Remove win32_so_ops settings. Don't set > > current_target_so_ops here. > > > > * Makefile.in (i386_cygwin_tdep_h): New variable. > > (i386-cygwin-tdep.o): Update dependencies. > > (win32-nat.o): Update dependencies. It looks like this change makes it necessary to have libexpat installed for DLLs support to work. Am I right? I'm looking for a simple way of avoiding this dependency, but I can't find any at the moment :-(. Given the growing importance that XML is taking in GDB, maybe there will be a day when it is worth having a copy of the expat sources in GDB, and always build with expat. -- Joel