From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17070 invoked by alias); 10 Oct 2007 12:01:49 -0000 Received: (qmail 17057 invoked by uid 22791); 10 Oct 2007 12:01:48 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 10 Oct 2007 12:01:42 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0D6A99833A; Wed, 10 Oct 2007 12:01:41 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id E9F8898339; Wed, 10 Oct 2007 12:01:40 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IfaFw-0002kM-9S; Wed, 10 Oct 2007 08:01:40 -0400 Date: Wed, 10 Oct 2007 12:18:00 -0000 From: 'Daniel Jacobowitz' To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFA] gdb_ari.sh patch to eliminate wrong critical errors Message-ID: <20071010120140.GB10228@caradoc.them.org> Mail-Followup-To: Pierre Muller , gdb-patches@sourceware.org References: <000001c80b14$db947450$92bd5cf0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000001c80b14$db947450$92bd5cf0$@u-strasbg.fr> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00230.txt.bz2 On Wed, Oct 10, 2007 at 10:09:18AM +0200, Pierre Muller wrote: > I tested this locally and it does reduce the > number of critical entries to 4. > > Daniel, could you please commit this? Done. > Remaining problems are: > 1) inline 9 Do not use the inline attribute; > since the compiler generally ignores this, better > algorithm selection is needed to improved performance > This problem is limited to three files: > vec.c (1) vec.h (7) and xtensa-tdep.c (1). > It could be easily removed, but I was wondering if > there was a special reason why vec.h > had some many. No really good reason. The above is someone's particular opinion on the inline keyword (probably Andrew's, as he wrote the ARI stuff, but I don't know for sure who - maybe someone else on the list knows). vec.c / vec.h were written by Nathan for GCC, and the GCC project has a very different opinion on the use of the inline keyword. Perhaps the fact that the compiler sources think inline is worthwhile should give us a hint... > 3) hash 3 Do not use ` #...', instead use `#...' > (some compilers only correctly parse a C preprocessor directive > when `#' is the first character on the line) > This 3 appearances are in: > ada-lex.c (2) and xtensa-tdep.c (1) > But ada-lex.c is an automatically generated file, and I am even wondering > why > this file is checked. Probably shouldn't be. > 4) obsolete system 2 No config file for system > These 2 entries are configure.host and configure.tgt > which are again generated files... No they aren't. They're maintained by hand. I can not figure out where this message comes from or what it means. -- Daniel Jacobowitz CodeSourcery