Re: [rfc] [00/16] Get rid of current gdbarch

Maxim Grigoriev
2007-10-08T17:53:38Z

Hello, Markus,

I think you missed xtenda-tdep.c.
First time, you asked for an approval but never checked the patch in.

What do you want me to do : to wait until you update it and then test
it, or just go ahead and do it by myself ?

-- Maxim

Markus Deuling wrote:
> Hi,
>
> a while ago I sent a first patch set to get rid of current_gdbarch. I
> now added some patches and deferred some other and reworked the
> ChangeLog entries due to feedback from you. Now that 6.7 branch was
> created this is a reworked patch set for current head.
>
> This patch set is another step in the direction of per-frame
> architecture. This set of 16 patches replaces (trivial to replace
> occurences of) current_gdbarch by appropriate methods like
> get_frame_arch or get_regcache_arch etc.
>
> Currently get_frame_arch just returns current_gdbarch but this will be
> replaced by later patches.
>
> I tested this patch set on x86 native and remote by compiling and
> running the testsuite. I also did a gdb_mbuild with all
> targets to make sure it compiles.
>
> Some later patches will be non-trivial and hard for me to test due to
> lack of those machines. It would be great if some of you could test
> patches for different archs like mips, arm, etc. but this will still
> take a while.
>
> This patch set replaces some of the current_gdbarch's in following files:
>
> * aix-thread.c
> * arm-tdep.c
> * alpha-{linux-nat,nat,tdep}.c
> * findvar.c
> * amd64-{nat,tdep}.c
> * i386-tdep.c
> * sh[64]-tdep.c
> * remote.c
> * irix5-nat.c
> * regcache.c
> * m68k{linux-nat, linux-tdep, -tdep}.c
> * dwarf2{loc, -frame}.c
> * cris-tdep.c
> * hppa-{hpux-nat, hpux-tdep, linux-nat, tdep}.c
>
> Is this ok?
>
>
>