Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Luis Machado <luisgpm@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] PPC Call-clobbered registers testcase
Date: Mon, 08 Oct 2007 19:06:00 -0000	[thread overview]
Message-ID: <20071008185507.GA28479@caradoc.them.org> (raw)
In-Reply-To: <1191869140.4322.10.camel@localhost>

On Mon, Oct 08, 2007 at 03:45:40PM -0300, Luis Machado wrote:
> Thanks for reviewing,
> 
> Hopefully i addressed all of the issues in this updated version. I'm
> aiming at gdb.opt for this one.

I think this won't work without a bit of extra work to add the new
directory, e.g. during configure.  But I can take care of that.

> As for the last comment, about passing on correct values, the correct
> behaviour, at least in this test case, is for GDB to display those
> values as optimized since they no longer are proven to be correct.
> Anything i'm failing to see in this case?

Yes.  If the test runs on x86, they may not be in registers - so they
may still be known, if they were stored on the stack.

Other than that, the testcase looks fine to me.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-10-08 18:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-24 14:41 Luis Machado
2007-09-25 16:21 ` Luis Machado
2007-10-06 16:12   ` Daniel Jacobowitz
2007-10-08 18:55     ` Luis Machado
2007-10-08 19:06       ` Daniel Jacobowitz [this message]
2007-10-08 19:14         ` Luis Machado
2007-10-08 19:35           ` Daniel Jacobowitz
2007-10-23 22:18             ` Luis Machado
2007-10-24 21:00               ` Daniel Jacobowitz
2007-10-25 19:06                 ` Luis Machado
2007-10-25 19:30                   ` Daniel Jacobowitz
2007-10-25 20:36                     ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071008185507.GA28479@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=luisgpm@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox