From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>, gdb-patches@sourceware.org
Subject: Re: [RFA] ARI fix: Remove asprintf in breakpoint.c
Date: Mon, 08 Oct 2007 16:25:00 -0000 [thread overview]
Message-ID: <20071008162456.GP3570@adacore.com> (raw)
In-Reply-To: <20071008160904.GA19094@caradoc.them.org>
> > Concerning the overnight running of testsuites
> > with different patches, does anyone have some
> > script that automates this?
>
> No - but it's reasonable to test them together in a single test run,
> I think.
That's indeed what I meant. However, I can see the need for a script
if you have to do two runs (one before patching, and one after).
I have a set of scripts that I can send, but they are deeply
dependent on my entire environment (including the interactive shell
sessions). My scripts are pretty complex because I re-use them in
many different contexts on 3 different sites (in Paris, in New York,
and at my home). Unless someone else can share a script, I think it'll
be simpler for you to write a script of your own.
The essence of my script is:
- Take patch name from argument lists.
Verify that patch exists before continuing. Nothing worse than having
a failure 12hours later because you mistyped your patch name :)
- mkdir test-dir
- cd test-dir
- cp -R gdb-sources .
- cd gdb-sources
- configure
- make
- cd gdb/testsuite
- make check
- cp gdb.sum gdb.sum.ref
- cp gdb.log gdb.log.ref
- cd ..
- patch -p0 < your-patch
- make
- cd testsuite
- make check
(with various checks against $? at the end of steps such as the
GDB build, so that you don't continue if something failed).
As I said, if the stream of your patches is relatively small,
I don't mind doing the testing for you, since it's pretty automated
on my side. But if you are going to contribute a regular amount
of patches, it makes sense to invest the time in them.
--
Joel
next prev parent reply other threads:[~2007-10-08 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 12:21 Pierre Muller
2007-10-08 13:42 ` Joel Brobecker
2007-10-08 13:51 ` Pierre Muller
2007-10-08 15:02 ` Joel Brobecker
2007-10-08 15:24 ` Pierre Muller
2007-10-08 16:09 ` Daniel Jacobowitz
2007-10-08 16:25 ` Joel Brobecker [this message]
2007-10-08 17:18 ` Daniel Jacobowitz
2007-10-08 19:38 ` Pedro Alves
2007-10-09 14:46 ` Pierre Muller
2007-10-09 16:08 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071008162456.GP3570@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox