From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Markus Deuling <deuling@de.ibm.com>,
GDB Patches <gdb-patches@sourceware.org>,
Eli Zaretskii <eliz@gnu.org>,
Joel Brobecker <brobecker@adacore.com>,
Jim Blandy <jimb@codesourcery.com>,
rearnsha@arm.com, Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [rfc] [00/16] Get rid of current gdbarch
Date: Mon, 08 Oct 2007 13:35:00 -0000 [thread overview]
Message-ID: <20071008133525.GA10323@caradoc.them.org> (raw)
In-Reply-To: <200710081302.l98D2pKk010603@d12av02.megacenter.de.ibm.com>
On Mon, Oct 08, 2007 at 03:02:51PM +0200, Ulrich Weigand wrote:
> You should not call get_current_frame at this point; this might
> in fact fail as there is not necessarily a current frame selected
> at the point this callback is called.
>
> Instead, you should change the XXX_reg_to_regnum gdbarch entries
> from type "f" to "m"; then the functions will be automatically
> provided with a gdbarch parameter. (This should be a separate
> patch from the remaining trivial current_gdbarch replacements.)
/* This will hopefully provoke a warning. */
- return gdbarch_num_regs (current_gdbarch)
- + gdbarch_num_pseudo_regs (current_gdbarch);
+ return gdbarch_num_regs (gdbarch)
+ + gdbarch_num_pseudo_regs (gdbarch);
That's the only thing it's used for. Does it provoke a warning? If
not, maybe -1 or something similar should...
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-10-08 13:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 8:18 Markus Deuling
2007-10-08 13:03 ` Ulrich Weigand
2007-10-08 13:22 ` Markus Deuling
2007-10-08 13:35 ` Daniel Jacobowitz [this message]
2007-10-08 14:01 ` Ulrich Weigand
2007-10-08 14:10 ` Daniel Jacobowitz
2007-10-09 20:03 ` Ulrich Weigand
2007-10-09 21:39 ` Daniel Jacobowitz
2007-10-10 11:54 ` Mark Kettenis
2007-10-10 12:01 ` Daniel Jacobowitz
2007-10-08 13:16 ` Joel Brobecker
2007-10-09 7:02 ` Markus Deuling
2007-10-08 17:53 ` Maxim Grigoriev
2007-10-09 5:10 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071008133525.GA10323@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=deuling@de.ibm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jimb@codesourcery.com \
--cc=mark.kettenis@xs4all.nl \
--cc=rearnsha@arm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox