Hi Eli, > Yuck! Can't we make pascal_main_name return `const char *'? If not, > why not? That's a good idea. What do you think about this revised version of Pierre's patch? 2007-10-07 Pierre Muller * p-lang.h (pascal_main_name): Add declaration. * p-lang.c (GPC_P_INITIALIZE, GPC_MAIN_PROGRAM_NAME_1) (GPC_MAIN_PROGRAM_NAME_2): New constants. (pascal_main_name): New function. * symtab.c: Include p-lang.h. (find_main_name): New function. * Makefile.in (symtab.o): Add dependency on p-lang.h. Pierre, This patch also implements the adjustments in the comments that I suggested. The way you wrote these commments made me think that you were implicitly thinking that your function is called only when the program is written in Pascal (and only in Pascal). But in fact, this is not the case, and the program could actually be multi-language! I also noticed some formatting issues, which I also fixed. I also just now noticed that I had some comments on your ChangeLog entry. Above is how I would write it: You were missing the '*' for each new file; And I made the text more concise (no need to explain what the function does for instance). I should have noticed that the first time around, but being new at reviewing patch, I'm still learning. -- Joel