Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: 'Daniel Jacobowitz' <drow@false.org>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org, gpc@gnu.de
Subject: Re: [RFC] adding gdb.pascal subdir: updated version
Date: Sat, 06 Oct 2007 15:42:00 -0000	[thread overview]
Message-ID: <20071006154209.GA7600@caradoc.them.org> (raw)
In-Reply-To: <001901c7f19f$db34e780$919eb680$@u-strasbg.fr>

On Sat, Sep 08, 2007 at 12:38:47AM +0200, Pierre Muller wrote:
> +proc test_string_literal_types_accepted {} {
> +    global gdb_prompt
> +
> +    # Test various character values.
> +
> +    gdb_test "pt 'a simple string'" "type = string"
> +}

Pierre, is this the correct Pascal syntax for a string or not?

We have:

    case '\'':
      /* We either have a character constant ('0' or '\177' for example)
         or we have a quoted symbol reference ('foo(int,int)' in object pascal
         for example). */

and there is a separate case for double-quoted strings.

Resolving that question will take care of one failure for both fpc and
gpc.  The other two GPC failures should be handled like in the patch
I've attached.  The failure at "start" is a GDB bug, so we label that
a KFAIL ("known failure").  The shouldn't be committed with gdb/NNNN
still in it.  It should either have a bug number in our bug database,
or else just wait until the patch to fix it is checked in.

The other test is definitely a bug in GPC.  I read through the DWARF
dump and there is no reference to line 10, so GDB will never display
it.  So that's an XFAIL, an expected failure due to our environment.
It needs to get a little more complicated if the GPC bug is fixed
some day, using gdb_test_multiple.

-- 
Daniel Jacobowitz
CodeSourcery

diff -u gdb.pascal/hello.exp gdb.pascal/hello.exp
--- gdb.pascal/hello.exp	7 Sep 2007 21:46:31 -0000
+++ gdb.pascal/hello.exp	6 Oct 2007 15:39:32 -0000
@@ -50,6 +50,9 @@
 # This test fails for gpc
 # because debug information for 'main'
 # is in some <implicit code>
+if { $pascal_compiler_is_gpc } {
+    setup_kfail *-*-* gdb/NNNN
+}
 gdb_test "" \
          ".* at .*hello.pas.*" \
          "start"
@@ -64,6 +67,9 @@
 # This test also fails for gpc because the program
 # stops after the string has been written
 # while it should stop before writing it 
+if { $pascal_compiler_is_gpc } {
+    setup_xfail *-*-*
+}
 gdb_test "cont" \
 	 "Breakpoint .*:${bp_location2}.*" \
 	 "Going to second breakpoint"


  parent reply	other threads:[~2007-10-06 15:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <000601c77c0a$26b91750$742b45f0$@u-strasbg.fr>
     [not found] ` <20070412154722.GA4189@caradoc.them.org>
     [not found]   ` <001201c77de2$008bc7b0$01a35710$@u-strasbg.fr>
     [not found]     ` <002a01c7b3cf$1cd594f0$5680bed0$@u-strasbg.fr>
     [not found]       ` <20070705143246.GA4958@caradoc.them.org>
2007-07-17 22:17         ` [RFC] adding gdb.pascal subdir Pierre Muller
2007-07-18  9:16           ` 'Daniel Jacobowitz'
2007-07-18 12:39             ` Pierre Muller
2007-09-07 22:16             ` [RFC] adding gdb.pascal subdir: updated version Pierre Muller
2007-09-07 22:38               ` Pierre Muller
2007-09-07 22:45                 ` Maxim Grigoriev
2007-10-06 15:42                 ` 'Daniel Jacobowitz' [this message]
2007-10-08  7:14                   ` Pierre Muller
2007-10-08 12:03                     ` 'Daniel Jacobowitz'
2007-10-08 12:17                       ` Pierre Muller
2007-10-08 12:42                         ` 'Daniel Jacobowitz'
2007-10-08 13:42                           ` Pierre Muller
2007-10-08 13:56                             ` 'Daniel Jacobowitz'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071006154209.GA7600@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=gpc@gnu.de \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox