Re: [patch] early abort if child spawning failed

Mike Frysinger
2007-09-22T04:18:55Z

On 9/21/07, Daniel Jacobowitz <drow@false.org> wrote:
> On Fri, Sep 21, 2007 at 10:31:11PM -0400, Mike Frysinger wrote:
> > if you use gdbserver to listen on a port and the specified program fails to
> > launch properly, the server process will continue on to the accept() call and
> > sit there forever ... you cant control+c the process as the signals are taken
> > over which means you have to connect with gdb to force the server to re-check
> > itself and then abort ... all in all, a pita for a simple typo.
> >
> > the attached patch checks the status field immediately after launch rather
> > than falling down into the main loop and waiting for the remote debugger to
> > connect for the status to get properly checked.
>
> Did you port this from an earlier version?

yep

> It shouldn't be necessary any more - Michael fixed this 2007-07-27.

when i looked at the CVS HEAD version, the comment "we assume success"
led me to believe that the situation was unchanged ... but looking at
the diff, the patch i proposed is pretty much the same as the one
Michael proposed so yeah, what i posted can just be dropped ...

thanks
-mike