From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30933 invoked by alias); 21 Sep 2007 22:19:44 -0000 Received: (qmail 30925 invoked by uid 22791); 21 Sep 2007 22:19:44 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Sep 2007 22:19:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 343512AA839; Fri, 21 Sep 2007 18:19:40 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KriNvHEnPAOK; Fri, 21 Sep 2007 18:19:40 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EF0E32AA7D6; Fri, 21 Sep 2007 18:19:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E3AD4E7B58; Fri, 21 Sep 2007 15:19:37 -0700 (PDT) Date: Fri, 21 Sep 2007 22:19:00 -0000 From: Joel Brobecker To: Jim Blandy Cc: gdb-patches@sourceware.org Subject: Re: RFC: Fix qOffsets handling Message-ID: <20070921221937.GB3963@adacore.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00282.txt.bz2 > Daniel Jacobowitz has approved this change off-list, and asked me to > suggest it be included on the 6.7 branch as well. I'll wait for > further comments here, and commit to trunk on Monday; Joel, is this > okay for the branch? Sure! I agree it should be applied to the branch as well. > > gdb/ChangeLog: > 2007-09-21 Jim Blandy > > * symfile.h (struct symfile_segment_data): Doc fixes. > * symfile.c (symfile_map_offsets_to_segments): Doc fixes. > Assert that we were passed some loaded segment addresses, > and that sections' segment numbers are valid. > Simplify offset calculation. > * remote.c (get_offsets): Clarify selection of relocate-by-segment > strategy, and set num_segments correctly. Delete redundant > assignments to do_sections. Thanks, -- Joel