From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50867-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31021 invoked by alias); 21 Sep 2007 07:48:58 -0000
Received: (qmail 31011 invoked by uid 22791); 21 Sep 2007 07:48:58 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Sep 2007 07:48:53 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.0) with ESMTP id l8L7mmpJ013527; 	Fri, 21 Sep 2007 09:48:48 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id l8L7mlOG000473; 	Fri, 21 Sep 2007 09:48:47 +0200 (CEST)
Date: Fri, 21 Sep 2007 07:48:00 -0000
Message-Id: <200709210748.l8L7mlOG000473@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
CC: gdb-patches@sourceware.org
In-reply-to: <20070920211311.GA4363@adacore.com> (message from Joel Brobecker 	on Thu, 20 Sep 2007 14:13:11 -0700)
Subject: Re: [RFC/commit] Getting rid of tm-rs6000.h (PROCESS_LINENUMBER_HOOK)
References: <20070918231448.GS29127@adacore.com> <200709200610.l8K6AeV1018876@brahms.sibelius.xs4all.nl> <20070920063714.GA16312@adacore.com> <20070920211311.GA4363@adacore.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-09/txt/msg00276.txt.bz2

> Date: Thu, 20 Sep 2007 14:13:11 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> --+HP7ph2BbKc20aGI
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> 
> > What do you think about adding a new method inside struct sym_fns: 
> > 
> >         void (*sym_read_linetable) (void)
> > 
> > It would be null for all object formats except XCOFF.
> > 
> > I'll experiment with that... Thanks for your feedback!
> 
> Here is a patch that implements exactly this.
> 
> 2007-09-20  Joel Brobecker  <brobecker@adacore.com>
> 
>         * symfile.h (struct sym_fns): Add new field sym_read_linetable.
>         * coffread.c, dbxread.c, elfread.c, mipsread.c somread.c:
>         Adjust the struct sym_fns object accordingly by setting
>         the new field to NULL.
>         * xcoffread.c (aix_process_linenos): Make static.
>         (xcoff_sym_fns): Set new field to aix_process_linenos.
>         * buildsym.c (end_symtab): Replace call to PROCESS_LINENUMBER_HOOK
>         by call to new the new sym_fns sym_read_linetable function.
>         * config/powerpc/aix.mt (DEPRECATED_TM_FILE): Delete.
>         * config/rs6000/tm-rs6000.h: Delete.
> 
> Tested on powerpc-aix and x86-linux, no regression. Does it look good?

Looks very good to me.

Mark