From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24594 invoked by alias); 20 Sep 2007 06:37:25 -0000 Received: (qmail 24582 invoked by uid 22791); 20 Sep 2007 06:37:24 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Sep 2007 06:37:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D99482AAF67; Thu, 20 Sep 2007 02:37:16 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8JR6WzSkStKO; Thu, 20 Sep 2007 02:37:16 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9ACC42AA2E7; Thu, 20 Sep 2007 02:37:16 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 6482EE7B58; Wed, 19 Sep 2007 23:37:14 -0700 (PDT) Date: Thu, 20 Sep 2007 06:37:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [RFC/commit] Getting rid of tm-rs6000.h (PROCESS_LINENUMBER_HOOK) Message-ID: <20070920063714.GA16312@adacore.com> References: <20070918231448.GS29127@adacore.com> <200709200610.l8K6AeV1018876@brahms.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200709200610.l8K6AeV1018876@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00267.txt.bz2 Hi Mark, > > The AIX port is the only port that defines this macro, and it's only > > used in one place: buildsym.c:end_symtab(). I think the most appropriate > > way to define this notion is as a gdbarch method, set only in the case > > of AIX. This is what this patch does. > > Hmm, if this is something that is purely for a specific object/debug format, > I think the gdbarch vector is the wrong place to put it. Since the gdbarch vector is dependent on the ABI, we can set the method when identifying XCOFF objects. That seemed the simplest approach at the time. But I agree that this is borderline. What do you think about adding a new method inside struct sym_fns: void (*sym_read_linetable) (void) It would be null for all object formats except XCOFF. I'll experiment with that... Thanks for your feedback! -- Joel